Empty state: add text wrap balance to empty state text #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ju-Skinner
pushed a commit
that referenced
this pull request
Nov 22, 2024
* style: adjust padding on bulk actions (#2023) * style(empty state): add text wrap balance to empty state text (#2026) * chore(deps): bump @pine-ds/icons from 8.10.0 to 8.11.0 (#2025) Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.10.0 to 8.11.0. - [Release notes](https://github.com/Kajabi/pine-icons/releases) - [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md) - [Commits](Kajabi/pine-icons@v8.10.0...v8.11.0) --- updated-dependencies: - dependency-name: "@pine-ds/icons" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Monica Wheeler <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DSS-1195
Implement
text-wrap: balanceto create a more visually appealing appearance to text in an empty state. Balancing the text wrapping leads to even distribution of text between lines, making the text easier to read and more aesthetically pleasing.Browser support is supported across the major browsers: Chrome, Firefox, Edge, and Safari
Solution
text-wrap: balanceto.sage-empty-state__textScreenshots
Testing in
sage-libTesting in
kajabi-products